Author Topic: Multiple Comment then Uncomment Either Crush the HE or do not uncomment  (Read 3862 times)

Offline Arthur

  • Registered User
  • Hero Member
  • *
  • Posts: 653
  • Karma: +1/-0
  • He who is ashamed of asking is afraid of learning.
    • View Profile
    • My Blog
Well, try the following:

1) you have the following text
USE Northwind;
GO

2) Comment several times (2+) it when the cursor is there:

USE Northwind;
G|O

3) Uncomment and get

U/*SE Northwind;

Offline Arthur

  • Registered User
  • Hero Member
  • *
  • Posts: 653
  • Karma: +1/-0
  • He who is ashamed of asking is afraid of learning.
    • View Profile
    • My Blog
Oh and the crash occurs when you mix the comments up in an SQL file at least, so if you position the cursor differently within the text and comment/uncomment eventually HE will exit.

Offline Arthur

  • Registered User
  • Hero Member
  • *
  • Posts: 653
  • Karma: +1/-0
  • He who is ashamed of asking is afraid of learning.
    • View Profile
    • My Blog
And, at some point after that doing just an undo I am getting a window

---------------------------
HippoEDIT
---------------------------
The parameter is incorrect.


---------------------------
OK   
---------------------------

Offline Arthur

  • Registered User
  • Hero Member
  • *
  • Posts: 653
  • Karma: +1/-0
  • He who is ashamed of asking is afraid of learning.
    • View Profile
    • My Blog
Aha, I now can reproduce the crashes at will:

I can do

a) the -- comment by selecting the whole lines, then
b) position the cursor in the middle of the text block,
c) now if you do multiple comments (/* */) then undo them HE closes off.

Offline alex

  • Developer
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2183
  • Karma: +37/-3
    • View Profile
    • HippoEDIT
Hi Arthur,

I can reproduce situation with:
Quote
3) Uncomment and get
U/*SE Northwind;
Would try to fix today version.

But crash I cul not reproduce even wit this example:
Quote
a) the -- comment by selecting the whole lines, then
b) position the cursor in the middle of the text block,
c) now if you do multiple comments (/* */) then undo them HE closes off.

I see some problems with multi line undo, maybe they were reason, let us see with new beta.
Thanks for a bug report!

Best regards,
Alex
« Last Edit: May 25, 2009, 08:37:31 pm by alex »

Offline Arthur

  • Registered User
  • Hero Member
  • *
  • Posts: 653
  • Karma: +1/-0
  • He who is ashamed of asking is afraid of learning.
    • View Profile
    • My Blog
Quote
But crash I cul not reproduce even wit this example:

Quote
a) the -- comment by selecting the whole lines, then
b) position the cursor in the middle of the text block,
c) now if you do multiple comments (/* */) then undo them HE closes off.

I could again, this is just a matter of doing that several times, do-undo - comment-uncomment. Trying to undo does not crash though, just flags off that message. Try just commenting say five times in a row then uncomment in /*-*/ mode.

Offline Arthur

  • Registered User
  • Hero Member
  • *
  • Posts: 653
  • Karma: +1/-0
  • He who is ashamed of asking is afraid of learning.
    • View Profile
    • My Blog
How to reproduce for sure (it is happening fairly often):
1) Put the cursor like that
USE |Northwind;
Go;
so the highlight goes/crosses from one line to another.
2) Start commenting 20+ times then just start uncommenting (perhaps you need to reposition the cursor at some point in time), boom it goes! Btw, if you make the cursor positioned this way:
USE Northwind;
G|o
or perhaps anyways HE will bomb. I also go the parameter error by just uncommenting. So the key is to comment multiple times.

So, the other time I got the exit condition I allowed the VS debugger to take over the crash, the ending was:

The thread 'Win32 Thread' (0x27c) has exited with code -1073741811 (0xc000000d).
The thread 'Win32 Thread' (0x1400) has exited with code -1073741811 (0xc000000d).
The thread 'Win32 Thread' (0x49c) has exited with code -1073741811 (0xc000000d).
The thread 'Win32 Thread' (0x3d4) has exited with code -1073741811 (0xc000000d).
The thread 'Win32 Thread' (0x7e4) has exited with code -1073741811 (0xc000000d).
The thread 'Win32 Thread' (0x1714) has exited with code -1073741811 (0xc000000d).
The program '[5752] HippoEdit.exe: Native' has exited with code -1073741811 (0xc000000d).

Not sure if this is super helpful

Offline alex

  • Developer
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 2183
  • Karma: +37/-3
    • View Profile
    • HippoEDIT
Ok,

would try to check this once more in a week :)
New version with fix for mutiline comment just uploaded (history not yet updated, but it is there :) ). Ver 661.
Try with it, if still crashed, than I would check this later.

And thanks a lot for your efforts.

Best regards,
Alex.

Offline Arthur

  • Registered User
  • Hero Member
  • *
  • Posts: 653
  • Karma: +1/-0
  • He who is ashamed of asking is afraid of learning.
    • View Profile
    • My Blog
Thank you, and sorry, I want you to take a rest. Well, so far, after I took this build HE did not crash :)!

But after doing so many un-comments it simply stopped doing that at this:

USE /*/*/*/*/*Northwind;
Go;*/*/*/*/*/*/*/*/*/*/*/

Offline Arthur

  • Registered User
  • Hero Member
  • *
  • Posts: 653
  • Karma: +1/-0
  • He who is ashamed of asking is afraid of learning.
    • View Profile
    • My Blog
Aha, I can see the uncomment starts malfunctioning after some number of comments removed, e.g. I can get, and this is only if one repositions the cursor while commenting-uncommenting.

USE /*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*Northwind;
Go;*/*/*/*/*/*/*/*/

This is of course me humiliating poor HE  :-X

PS: So the count does get incorrectly as in the above even with very few un-comments like
USE N/*/*orthwind;
Go;*/*/*/
« Last Edit: May 25, 2009, 09:48:20 pm by Arthur »

 

Related Topics

  Subject / Started by Replies Last post
1 Replies
1690 Views
Last post March 31, 2009, 08:40:11 pm
by alex
3 Replies
1307 Views
Last post May 25, 2009, 05:07:54 pm
by alex
5 Replies
2154 Views
Last post June 25, 2009, 01:30:22 pm
by alex
3 Replies
3161 Views
Last post September 25, 2017, 10:51:40 pm
by alex
3 Replies
1165 Views
Last post May 08, 2015, 03:53:12 pm
by alex